New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action does not work behind a proxy - creating installation access token #44
Comments
ping @tibdex |
@abebehailu, do you have a fork with the fix? |
@sadovnikov Yes, here https://github.com/abebehailu/github-app-token. The octokit rest api from @actions/github uses the set proxy enviornment variables. Feel free to test it out from my fork. |
@tibdex can you deploy the latest version to Github marketplace? |
Done ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue: The part of the action that creates installation token does not work behind a proxy.
Reason: That part uses the @Octokit/request library to make a request to the access_token endpoint. That library in turn uses the library noda-fetch without sending in any proxy agent. The noda-fetch library does not check for http_proxy environment variables (node-fetch/node-fetch#195).
The call that fetches repo installation uses Octokit from the @actions/github library, which supports running behind a proxy.
Fix: Use @actions/github also for creating access token.
I have a simple fix for this but I need write access to be able to contribute.
The text was updated successfully, but these errors were encountered: