Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degradation due to 'token revocation' post script #88

Closed
drehelis opened this issue Sep 11, 2023 · 4 comments · Fixed by #95
Closed

Degradation due to 'token revocation' post script #88

drehelis opened this issue Sep 11, 2023 · 4 comments · Fixed by #95

Comments

@drehelis
Copy link

Token revocation has introduced a degradation to our workflows as we're using the token after the github action job is finished.
A switch whether a token should be deleted via post script or keep the old behaviour would be much appreciated.

@Petru-NicuDumitrache-TomTom
Copy link

We have a similar (not identical) problem:
Some of our workflows have steps that take a long time (>1hr). The token is created and used at the start of the step. Afterwards the step does some computations taking a very long time. In the "Post" step, the action tries to revoke the token, which in the meantime expired, leading to an error.
post_error.txt

@tibdex
Copy link
Owner

tibdex commented Sep 19, 2023

Can you make your long computations block the progress of the workflow so that the post script of this GitHub Action won't be triggered before they finish?

@Petru-NicuDumitrache-TomTom

The Post does already trigger after the long computations.
It's just that by that time, the token is already gone from existence, so the action crashes trying to revoke it (I think).

@drehelis
Copy link
Author

@Petru-NicuDumitrache-TomTom we've switched to getsentry/action-github-app-token@v2 which does basically the same. Just FYI...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants