Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative import in plugins #22

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Fix relative import in plugins #22

wants to merge 18 commits into from

Conversation

AmeyaVS
Copy link
Contributor

@AmeyaVS AmeyaVS commented Mar 27, 2024

Note: This PR depends on #20

@AmeyaVS
Add Python 3.12 in GitHub Workflows
f77b6df
@AmeyaVS
Update GitHub Actions
f5962b3
@AmeyaVS
Fix typo
a9256dd
@AmeyaVS
Add dependency on packaging for Plugin Versioning
092d982 
Fix Attribute Error for importlib.util for standalone instllation of Yapsy
@AmeyaVS
Add trailing comma in-case of other dependencies
d4fdd34
@AmeyaVS
Initial Attempt at fixing relative imports in plugins
6c05a62
@AmeyaVS
Update Tests
19e5de9
@AmeyaVS
Remove URL
78343a3
@AmeyaVS
Temporarily disable failing assertion
f5a140e 
**Note:** For some reason the assertion do not fail locally
@AmeyaVS
Additional assertion removal temporarily
1246ad2
@AmeyaVS
Trying to revert changes for CI failure
52b8438
@AmeyaVS
Create Separate Test for Plugin As a Directory with relative imports …
b85e072 
…for now.
@AmeyaVS
Reverted to previous implementation added a importlib.machinery.Sourc…
837217f 
…eFileLoader
@AmeyaVS
Implementation Cleanup
cc48b5c
@AmeyaVS
Fix module not found due to incorrect class specifications
0bd1300
@AmeyaVS
Add Fix for relative import for packages requires a submodule_search_…
a359b11 
…location parameter to be passed to spec_from_file_location
@coveralls
Copy link

coveralls commented Mar 27, 2024 •
edited
Loading

Coverage Status

coverage: 91.068% (-0.4%) from 91.489%
when pulling 702a549 on AmeyaVS:fix_relative_import_in_plugins
into 6b487b0 on tibonihoo:master.

@AmeyaVS
Copy link
Contributor Author

AmeyaVS commented Apr 3, 2024

@tibonihoo , can you review these changes?

@AmeyaVS
Copy link
Contributor Author

AmeyaVS commented Apr 28, 2024

Hi @tibonihoo , would you be able to review these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't load plugins with relative imports anymore
2 participants
@AmeyaVS @coveralls