Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append timestamp to messages #68

Open
git-sid opened this issue Dec 21, 2018 · 3 comments
Open

Append timestamp to messages #68

git-sid opened this issue Dec 21, 2018 · 3 comments
Labels
enhancement good first issue Want to get started with contributing? This is easy to implement.

Comments

@git-sid
Copy link
Contributor

git-sid commented Dec 21, 2018

I'd be great to append the timestamp to the message itself. At the moment, messages take ~8 minutes to reach the end user. With timestamps we could at least work around this problem until it is fixed.

@b3yond
Copy link
Member

b3yond commented Dec 24, 2018

Sometimes people add manual timestamps, because they can only now report an event which was 20 minutes ago. We need to check whether a message already has a timestamp before appending one.

@git-sid
Copy link
Contributor Author

git-sid commented Dec 27, 2018

actually we don't have to.
If a person reports an event that happened 20 minutes ago, i would still take x time to be shared. The message would therefore still be out if sync; even with timestamp.
We need to take the time of the message object and use that as timestamp

@b3yond
Copy link
Member

b3yond commented Jan 6, 2019

ah now I understand what you mean:

  1. person sees controllers at 12:00
  2. person tweets about it at 12:20
  3. ticketfrei retweets at 12:25

With your proposal to timestamp everything, out of the tweet 1200 controllers at $place would become 12:20 1200 controllers at $place. It would appear at 12:25.

I think the person always knows better than ticketfrei when the controls happened. Meaning:

  • if the person already posted a timestamp, we should not add one.
  • Also, if the report happened not longer than a minute ago, we could leave out the timestamps.

In any other case, let's append a timestamp.

@git-sid git-sid added the good first issue Want to get started with contributing? This is easy to implement. label Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Want to get started with contributing? This is easy to implement.
Projects
None yet
Development

No branches or pull requests

2 participants