Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed has no effect on synths and soundfonts #1057

Open
felixroos opened this issue Apr 17, 2024 · 1 comment
Open

speed has no effect on synths and soundfonts #1057

felixroos opened this issue Apr 17, 2024 · 1 comment
Labels
enhancement improves an existing feature

Comments

@felixroos
Copy link
Collaborator

probably makes sense to make it have an effect, just as a frequency multiplier, so functions like hurry would work as expected.
in the case of soundfonts, it should make sense to multiply it with the frequency after the sample has been selected, so that the repitch actually sounds like a repitch, instead of getting a sample in a different zone.
this is a breaking change but might not affect a lot of patterns

@felixroos felixroos added the enhancement improves an existing feature label Apr 17, 2024
@yaxu
Copy link
Member

yaxu commented Apr 17, 2024

Superdirt takes the absolute value of speed before multiplying, probably makes sense, although might it also be nice to reverse the envelopes for negative speeds somehow..

https://github.com/musikinformatik/SuperDirt/blob/c7f32998572984705d340e7c1b9ed9ad998a39b6/classes/SuperDirtUGens.sc#L159-L169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improves an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants