Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample volume/gain #17

Closed
annybs opened this issue Mar 13, 2014 · 4 comments
Closed

Sample volume/gain #17

annybs opened this issue Mar 13, 2014 · 4 comments

Comments

@annybs
Copy link
Contributor

annybs commented Mar 13, 2014

I haven't had a serious need for this yet, but the volume of some of the samples bundled with Dirt proved problematic when I played live with a friend a couple of months ago, and it's only just occurred to me to bring this up now...

I've looked through the tidal and dirt codebases and I've noted gain and velocity in places, but I've not been able to apply either (or at least they don't seem to have any effect.)

Is it the case that this already a feature and I'm just using it wrong, or is this legitimately not yet implemented?

@yaxu
Copy link
Member

yaxu commented Mar 13, 2014

It's half-implemented, nearly there, just needs a bit more time..

@yaxu
Copy link
Member

yaxu commented Mar 28, 2014

Should work now finally, you'll need to update tidal too otherwise everything will be silent..

@yaxu yaxu closed this as completed Mar 28, 2014
@annybs
Copy link
Contributor Author

annybs commented Mar 28, 2014

Great stuff, just updated dirt and tidal and it works exactly as I hoped; 0 silent → 1 full volume.

Just for reference, any idea what happens with values > 1 or < 0? I expect that negative values just won't work. Can gain be increased beyond the sample volume or does it top out at 1?

@yaxu
Copy link
Member

yaxu commented Mar 28, 2014

1 will keep getting louder - watch your speakers!

< 0 will just invert the signal, so according to my understanding gain of -1 should sound identical to 1

yaxu added a commit that referenced this issue Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants