Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -1 default parameters #89

Closed
telephon opened this issue Jan 22, 2016 · 1 comment
Closed

remove -1 default parameters #89

telephon opened this issue Jan 22, 2016 · 1 comment

Comments

@telephon
Copy link
Contributor

Currently, we have this:

delayfeedback :: Pattern Double -> ParamPattern
delayfeedback = make' VF delayfeedback_p
delayfeedback_p = F "delayfeedback" (Just (-1))

Which will send -1 instead of nothing. Assuming that delay is the "keyword" that will say that you want to actually use the delay, there seems to be no reason why we shouldn't just send nil (aka Nothing) instead.

The current behaviour requires special treatment of the delaytime and delayfeedback parameters.

@lennart
Copy link
Contributor

lennart commented Dec 21, 2016

see #152 for reasons why we keep these defaults.

@lennart lennart closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants