Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: get rid of fallback boot parameters #40

Open
crcdng opened this issue Jun 13, 2023 · 0 comments
Open

Proposal: get rid of fallback boot parameters #40

crcdng opened this issue Jun 13, 2023 · 0 comments

Comments

@crcdng
Copy link

crcdng commented Jun 13, 2023

Fallback boot parameters defined in

bootCommands: string[] = [
are silently applied when no path to BootTidal.hs is defined. This might appear convenient, however it can lead to hard to track errors as the boot parameter sets in this file and in BootTidal.hs almost certainly will continue to diverge.

This problem should be made explicit to the user.

As a solution, I suggest to remove the fallback parameters. The plugin would then require to enter the path to BootTidal.hs. If Tidal is installed before the plugin it can pre-populate the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant