Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kv/config): support to customize log level via env #324

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

WenyXu
Copy link
Contributor

@WenyXu WenyXu commented Nov 27, 2021

I looked around the chatting groups and forums, saw that some students have no idea how to debug in Lab 2B. This commit is going to make the same debug experiences as the previous Lab, such as LAB 2A, which allows the users to set log levels via environment variables.

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2021

CLA assistant check
All committers have signed the CLA.

Author:    Weny Xu <wenymedia@gmail.com>
Date:      Sat Nov 27 10:37:00 2021 +0900
Copy link
Collaborator

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a hint about how to use it in doc

Copy link
Collaborator

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Connor1996 Connor1996 enabled auto-merge (squash) December 20, 2021 08:05
@Connor1996 Connor1996 merged commit 8b8fdd5 into talent-plan:course Dec 22, 2021
hidehalo pushed a commit to hidehalo/tinykv that referenced this pull request Jan 16, 2022
)

* feat(kv/config): support to customize log level via env

Author:    Weny Xu <wenymedia@gmail.com>
Date:      Sat Nov 27 10:37:00 2021 +0900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants