Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New app: UK opinion polls #2485

Merged
merged 1 commit into from
Jun 6, 2024
Merged

New app: UK opinion polls #2485

merged 1 commit into from
Jun 6, 2024

Conversation

dinosaursrarr
Copy link
Contributor

We're having a general election on 4 July, so it's relevant to keep track of how everyone is doing. Even if it is a pretty foregone conclusion in this case and we're going to get rid of the bastards at long long last

It does rely on web scraping, but it's pretty hard to find any kind of API that collects these kinds of table. The only ones I could find were the BBC and Wikipedia, and the BBC's is easier to parse. And I do pay my TV licence fee.

We're having a general election on 4 July, so it's relevant to keep track of how everyone is doing. Even if it is a pretty foregone conclusion in this case and we're going to get rid of the bastards at long long last
@tidbyt
Copy link

tidbyt bot commented May 25, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of bsoup.star requires review
Original Author The original author matches the PR author

@matslina matslina merged commit c42f4db into tidbyt:main Jun 6, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants