fix(ios): removing eventListener in location event will freeze app (#…

…12645) Fixes TIMOB-28275
tidev · Mar 23, 2021 · 0749a30 · 0749a30
1 parent a18fb68
commit 0749a30
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/iphone/TitaniumKit/TitaniumKit/Sources/API/ObjcProxy.m b/iphone/TitaniumKit/TitaniumKit/Sources/API/ObjcProxy.m
@@ -251,19 +251,22 @@ - (void)fireEvent:(NSString *)name withDict:(NSDictionary *)dict
   pthread_rwlock_rdlock(&_listenerLock);
   @try {
     if (_listeners == nil) {
+      pthread_rwlock_unlock(&_listenerLock);
       return;
     }
-    NSArray *listenersForType = [_listeners objectForKey:name];
+    NSArray *listenersForType = [[_listeners objectForKey:name] copy];
+    pthread_rwlock_unlock(&_listenerLock);
+
     if (listenersForType == nil) {
       return;
     }
     // FIXME: looks like we need to handle bubble logic/etc. See other fireEvent impl
     for (JSValue *storedCallback in listenersForType) {
       [self _fireEventToListener:name withObject:dict listener:storedCallback];
     }
+    [listenersForType autorelease];
   }
   @finally {
-    pthread_rwlock_unlock(&_listenerLock);
   }
 }