fix(android): prevent unnecessary channelId warning

tidev · Mar 27, 2020 · 1652d08 · 1652d08
1 parent aab53e7
commit 1652d08
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/...s/android/src/java/ti/modules/titanium/android/notificationmanager/NotificationProxy.java b/...s/android/src/java/ti/modules/titanium/android/notificationmanager/NotificationProxy.java
@@ -50,10 +50,7 @@ public NotificationProxy()
 		super();
 		notificationBuilder = new NotificationCompat.Builder(TiApplication.getInstance().getApplicationContext())
 								  .setSmallIcon(android.R.drawable.stat_sys_warning)
-								  .setWhen(System.currentTimeMillis())
-								  .setChannelId(NotificationManagerModule.useDefaultChannel()
-													? NotificationManagerModule.DEFAULT_CHANNEL_ID
-													: "miscellaneous"); // NotificationChannel.DEFAULT_CHANNEL_ID
+								  .setWhen(System.currentTimeMillis());
 
 		//set up default values
 		flags = Notification.FLAG_AUTO_CANCEL;
@@ -88,6 +85,10 @@ public void handleCreationDict(KrollDict d)
 		}
 		if (d.containsKey(TiC.PROPERTY_CHANNEL_ID)) {
 			setChannelId(d.getString(TiC.PROPERTY_CHANNEL_ID));
+		} else {
+			setChannelId(NotificationManagerModule.useDefaultChannel()
+							 ? NotificationManagerModule.DEFAULT_CHANNEL_ID
+							 : "miscellaneous"); // NotificationChannel.DEFAULT_CHANNEL_ID
 		}
 		if (d.containsKey(TiC.PROPERTY_CONTENT_VIEW)) {
 			setContentView((RemoteViewsProxy) d.get(TiC.PROPERTY_CONTENT_VIEW));