fix(android): softRestart() must account for snapshots (#11338)

maintain and rename global snapshot method Fixes TIMOB-27602
tidev · Nov 15, 2019 · 62a603d · 62a603d
1 parent 38ea44b
commit 62a603d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/android/titanium/src/java/org/appcelerator/titanium/TiApplication.java b/android/titanium/src/java/org/appcelerator/titanium/TiApplication.java
@@ -820,7 +820,15 @@ public void softRestart()
 		runtime.initRuntime();
 
 		// manually re-launch app
-		runtime.doRunModuleBytes(KrollAssetHelper.readAssetBytes(appPath), appPath, rootActivity.getActivityProxy());
+		if (KrollAssetHelper.assetExists(appPath)) {
+			runtime.doRunModuleBytes(KrollAssetHelper.readAssetBytes(appPath), appPath,
+									 rootActivity.getActivityProxy());
+
+			// launch script does not exist, must be using snapshot
+			// execute startup method baked in snapshot
+		} else {
+			runtime.doRunModule("global._startSnapshot(global)", appPath, rootActivity.getActivityProxy());
+		}
 	}
 
 	@Override

diff --git a/android/titanium/src/java/org/appcelerator/titanium/TiLaunchActivity.java b/android/titanium/src/java/org/appcelerator/titanium/TiLaunchActivity.java
@@ -104,7 +104,7 @@ protected void loadScript()
 				// launch script does not exist, must be using snapshot
 				// execute startup method baked in snapshot
 			} else {
-				KrollRuntime.getInstance().runModule("global.startSnapshot(global)", fullUrl, activityProxy);
+				KrollRuntime.getInstance().runModule("global._startSnapshot(global)", fullUrl, activityProxy);
 			}
 		} finally {
 			Log.d(TAG, "Signal JS loaded", Log.DEBUG_MODE);

diff --git a/build/lib/android/startup.ejs b/build/lib/android/startup.ejs
@@ -1,4 +1,3 @@
-this.startSnapshot = function (global) {
-    delete global.startSnapshot;
+this._startSnapshot = function (global) {
 <%- script %>
 }