Skip to content

Commit

Permalink
refactor(android): remove Ti.UI.WebView.onStopBlacklistedUrl event (#…
Browse files Browse the repository at this point in the history
…11361)

* refactor(webview): remove onStopBlacklistedUrl event

BREAKING CHANGE: The event was deprecated in SDK 6.1.0 and is now removed in 9.0.0. Please use
blacklisturl event instead

* docs(webview): mark onStopBlacklistedUrl event as removed in 9.0.0
  • Loading branch information
sgtcoolguy authored and lokeshchdhry committed Dec 9, 2019
1 parent 2c84e30 commit 85b32d8
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,6 @@ public boolean shouldOverrideUrlLoading(final WebView view, String url)
data.put("url", url);
data.put("message", "Webview did not load blacklisted url.");
proxy.fireEvent(TiC.PROPERTY_BLACKLIST_URL, data);

// Deprecated since 6.1.0, leave here until we remove it (7.0.0?)
proxy.fireEvent(TiC.PROPERTY_ON_STOP_BLACKLISTED_URL, data);

return true;
}
}
Expand Down
5 changes: 0 additions & 5 deletions android/titanium/src/java/org/appcelerator/titanium/TiC.java
Original file line number Diff line number Diff line change
Expand Up @@ -2438,11 +2438,6 @@ public class TiC
*/
public static final String PROPERTY_ON_STOP = "onStop";

/**
* @module.api
*/
public static final String PROPERTY_ON_STOP_BLACKLISTED_URL = "onStopBlacklistedUrl"; // Deprecated in 6.1.0

/**
* @module.api
*/
Expand Down
1 change: 1 addition & 0 deletions apidoc/Titanium/UI/WebView.yml
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,7 @@ events:
type: String
deprecated:
since: "6.1.0"
removed: "9.0.0"
notes: Use the cross-platform `blacklisturl` event instead.

- name: blacklisturl
Expand Down

0 comments on commit 85b32d8

Please sign in to comment.