fix(ios): set executionContext of TiStreamProxy (#12647)

Fixes TIMOB-28324
tidev · Mar 23, 2021 · a18fb68 · a18fb68
1 parent 6ffe8f9
commit a18fb68
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/iphone/Classes/FilesystemModule.m b/iphone/Classes/FilesystemModule.m
@@ -83,6 +83,7 @@ - (JSValue *)openStream:(TiStreamMode)mode
     if (fileProxy != nil) {
       NSArray *payload = @[ [NSNumber numberWithInt:mode] ];
       TiStreamProxy *streamProxy = [fileProxy open:payload];
+      streamProxy.executionContext = self.executionContext; //TIMOB-28324 Should we pass this executionContext in open function of TiFilesystemFileProxy?
       if (streamProxy != nil) {
         return [self NativeToJSValue:streamProxy];
       }

diff --git a/tests/Resources/ti.stream.test.js b/tests/Resources/ti.stream.test.js
@@ -458,4 +458,21 @@ describe('Titanium.Stream', function () {
 		totalsize = 0;
 		Ti.Stream.pump(blobStream, handler, chunksize, true);
 	});
+
+	it('pump - handler should be called(TIMOB-28324))', function (finish) {
+		var	sourceFile = Ti.Filesystem.getFile(Ti.Filesystem.applicationDataDirectory, 'streamfile.txt'),
+			sourceFileStream = Ti.Filesystem.openStream(Ti.Filesystem.MODE_READ, sourceFile.nativePath),
+			handlerCalled = false;
+
+		function handler() {
+			handlerCalled = true;
+		}
+
+		Ti.Stream.pump(sourceFileStream, handler, 20);
+		if (handlerCalled) {
+			finish();
+		} else {
+			finish(Error('Ti.Stream.pump handler not called.'));
+		}
+	});
 });