fix(buffer): allow setting falsy values through proxy (#11512)

common/Resources/ti.internal/extensions/node/buffer.js

@@ -1615,7 +1615,8 @@ const arrayIndexHandler = {
 		if (typeof propKey === 'string') {
 			const num = Number(propKey);
 			if (Number.isSafeInteger(num)) {
-				return setAdjustedIndex(target, num, value);
+				setAdjustedIndex(target, num, value);
+				return true;
 			}
 		}
 		return Reflect.set(target, propKey, value, receiver);
@@ -1644,7 +1645,6 @@ function setAdjustedIndex(buf, index, value) {
 	if (index >= 0 || index < buf._tiBuffer.length) {
 		buf._tiBuffer[index + buf.byteOffset] = value;
 	}
-	return value;
 }
 
 /**

tests/Resources/buffer.addontest.js

@@ -0,0 +1,17 @@
+'use strict';
+
+const should = require('./utilities/assertions');
+
+describe('buffer', () => {
+	it('supports array index access', () => {
+		const buf = Buffer.alloc(4);
+		should(buf.length).eql(4);
+		should(buf).eql(Buffer.from([ 0, 0, 0, 0 ]));
+		const values = [ 0, 1, 2, 3 ];
+		for (let i = 0; i < values.length; i++) {
+			buf[i] = values[i];
+			should(buf[i]).eql(values[i]);
+		}
+		should(buf).eql(Buffer.from(values));
+	});
+});