Skip to content

Commit

Permalink
fix(ios): remove deprecated UI appearance properties
Browse files Browse the repository at this point in the history
BREAKING CHANGES: removes Ti.UI.TextArea, Ti.UI.TextField appearance property (in favor of keyboardAppearance)
  • Loading branch information
sgtcoolguy committed Dec 16, 2019
1 parent 4ee9594 commit b8c1f84
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion iphone/Classes/TiUITextFieldProxy.m
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ @implementation TiUITextFieldProxy
DEFINE_DEF_INT_PROP(clearButtonMode, UITextFieldViewModeNever);
DEFINE_DEF_INT_PROP(leftButtonMode, UITextFieldViewModeNever);
DEFINE_DEF_INT_PROP(rightButtonMode, UITextFieldViewModeNever);
DEFINE_DEF_INT_PROP(appearance, UIKeyboardAppearanceDefault);
DEFINE_DEF_INT_PROP(keyboardAppearance, UIKeyboardAppearanceDefault);
DEFINE_DEF_INT_PROP(autocapitalization, UITextAutocapitalizationTypeNone);
DEFINE_DEF_INT_PROP(maxLength, -1);

Expand Down
10 changes: 0 additions & 10 deletions iphone/Classes/TiUITextWidget.m
Original file line number Diff line number Diff line change
Expand Up @@ -183,16 +183,6 @@ - (void)setPasswordRules_:(NSString *)passwordRules

#pragma mark Responder methods

- (void)setAppearance_:(id)value
{
NSString *className = [NSStringFromClass([self class]) substringFromIndex:4];
NSString *deprecatedApi = [NSString stringWithFormat:@"UI.%@%@", className, @".appearance"];
NSString *newApi = [NSString stringWithFormat:@"UI.%@%@", className, @".keyboardAppearance"];

DEPRECATED_REPLACED(deprecatedApi, @"5.2.0", newApi);
[self setKeyboardAppearance_:value];
}

- (void)setKeyboardAppearance_:(id)value
{
[[self textWidgetView] setKeyboardAppearance:[TiUtils intValue:value]];
Expand Down

0 comments on commit b8c1f84

Please sign in to comment.