Skip to content

Commit

Permalink
build(node): drop node 8, support node 10.13+, node 12 (#11336)
Browse files Browse the repository at this point in the history
* build(node): drop node 8, support node 10.13+, node 12

BREAKING CHANGE: Removal of Node 8 support, move to Node 10.13+

Fixes TIMOB-27605

* ci(jenkins): use node 10.17.0 to build/test
  • Loading branch information
sgtcoolguy authored and cb1kenobi committed Nov 18, 2019
1 parent 37b4e06 commit f35cf0e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def publishToS3 = isMainlineBranch // publish zips to S3 if on mainline branch,
def testOnDevices = isMainlineBranch // run tests on devices

// Variables we can change
def nodeVersion = '8.9.1' // NOTE that changing this requires we set up the desired version on jenkins master first!
def nodeVersion = '10.17.0' // NOTE that changing this requires we set up the desired version on jenkins master first!
def npmVersion = 'latest' // We can change this without any changes to Jenkins. 5.7.1 is minimum to use 'npm ci'

// Variables which we assign and share between nodes
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,10 @@
"visual studio": ">=10 <=12",
"windows phone sdk": "8.x",
"msbuild": ">=4.0",
"node": "8.x || 10.x"
"node": "10.x || 12.x"
},
"engines": {
"node": ">=8"
"node": ">=10.13"
},
"nyc": {
"exclude": [
Expand Down

0 comments on commit f35cf0e

Please sign in to comment.