Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix tabgroup layout on iOS 16+ #13522

Merged
merged 2 commits into from Aug 4, 2022

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Jul 31, 2022

Wow, that one was heavy to find out. Yet a simple and reasonable fix!

NOTE: Do not merge, yet. There is still a (maybe related) issue regarding x-spacing of the navigation bar.
It's unrelated, filing a new issue for this soon.

Test case:

const window1 = Ti.UI.createWindow({ title: 'Window 1', backgroundColor: 'blue' });
const window2 = Ti.UI.createWindow({ title: 'Window 2', backgroundColor: 'red' });
const window3 = Ti.UI.createWindow({ title: 'Window 3', backgroundColor: 'green' });

const tabGroup = Ti.UI.createTabGroup({
	tabs: [
		Ti.UI.createTab({ window: window1, title: 'Tab 1' }),
		Ti.UI.createTab({ window: window2, title: 'Tab 2' }),
		Ti.UI.createTab({ window: window3, title: 'Tab 3' })
	]
});

tabGroup.open();

Example:

Before After

Fixes #13479

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hansemannn hansemannn merged commit 5afeee0 into tidev:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 16: Tab Group not respecting safe area insets
2 participants