Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize environment check #1152

Open
m1ga opened this issue Jun 16, 2023 · 1 comment
Open

Optimize environment check #1152

m1ga opened this issue Jun 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@m1ga
Copy link
Contributor

m1ga commented Jun 16, 2023

Describe the Bug

Reported by a user on Slack:

After an update to Ventura 13.4 (M2 mac) VSCode suddenly stopped working and the environment wasn't found.
ti info still showed correct values but the package didn't find anything

image

the fix was to remove all testing SDK folders (stuff like 12.2.0.v20230413203758). So it might be that sdkVersions.sort((a, b) => { in src/environment-info.ts could be the issue.

I run an Intel Mac with 13.4 with Codium and have other SDK folder without any issue. So there might be other issues that cause this but we should verify the SDK check is working or at least gives a better output of the error. In the screenshot it even didn't find a node version.

@m1ga m1ga added the bug Something isn't working label Jun 16, 2023
@ewanharris
Copy link
Collaborator

So in terms of showing that screen, the ti info output won't have been loaded yet as it's in the startup/validation phase.

It'll be calling into titanium-editor-commons to validate the environment and then showing either "missing tooling", "environment issues" or continuing onto loading, the SDK check only uses GA SDKs so it's strange that removing CI SDKs fixed it.

Given that every check is failing it feels more potentially environment related rather than SDK version parsing failing, anecdotally I've seen issues where the extension host can get into a bad state and isn't able to resolve any information like node -v but it's hard to determine whether that is occurring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants