Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Docker Images? #6

Closed
pyrossh opened this issue Nov 6, 2016 · 4 comments
Closed

Docker Images? #6

pyrossh opened this issue Nov 6, 2016 · 4 comments

Comments

@pyrossh
Copy link

pyrossh commented Nov 6, 2016

I have made changes and added docker support and published the docker image.
Maybe it would better if you/I create an organization in docker and upload the image or you upload it under your name and we can add it in the README.

Here is the link to the repo,
https://hub.docker.com/r/pyros2097/summitdb/

I'll make a pull request for this also. I have started a cli so that people don't need to use redis-cli.

@tidwall
Copy link
Owner

tidwall commented Nov 7, 2016

Thanks for helping with this. I'm currently maintaining another database project Tile38 which has docker support. If possible I would prefer to use a similar Dockerfile for consistency and ease maintenance for me.

Basically theres a single docker directory which contains a Dockerfile and README. The Dockerfile then embeds the latest stable release. Please see Tile38#4 for the train of thought.

I have started a cli so that people don't need to use redis-cli.

I'm cool with this but I think it may be easy for me to review CLI codebase in a separate branch from the docker.

Let me know your thoughts on this, and thanks a ton for help.

@pteich
Copy link

pteich commented Nov 9, 2016

If you guys are interested, here is the Dockerfile for SummitDB I'm currently using: https://github.com/pteich/docker-summitdb

It's based on Alpine so it's pretty small and it doesn't build SummitDB from source but downloads a release from Github.

@pyrossh
Copy link
Author

pyrossh commented Nov 9, 2016

The one which I made is a statically linked executable which runs on the scratch docker image and is compressed using upx. So its 3mb is size. But yeah I think the releases way is the best to go.

@tidwall
Copy link
Owner

tidwall commented Nov 15, 2019

I'm closing this issue for now. I update the #7 PR with more details.

Also, I added a link in the README to the SummitDB options Docker Hub.

@pteich It looks like one of the options is yours.

@tidwall tidwall closed this as completed Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants