Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change locking activity on inactive issues #2

Open
brshallo opened this issue Jul 30, 2021 · 4 comments
Open

Change locking activity on inactive issues #2

brshallo opened this issue Jul 30, 2021 · 4 comments

Comments

@brshallo
Copy link

I request that old inactive (locked for comments) issues on tidymodels ( / tidyverse) packages still accumulate links when they are referenced in new issues or PRs. That way, users perusing old closed issues will be more easily linked to the most up-to-date issue(s) on a topic. (Particularly with locks happening after just 14 days after close.)

For example tidymodels/tune#215 was closed and locked. I opened and closed tidymodels/tune#381 with the intention that a link would be added at the bottom of #215 (as I'd referenced it) for anyone trying to do something similar. Yet because #215 was locked, no link to #381 was added. (This is an imperfect example as maybe I shouldn't have created #381 as it's essentially just a comment on a closed issue -- rather than a genuine bug or feature request -- which you are trying to limit. However in most cases continuing to accumulate links on old issues to newer topics may be valuable for people searching a pakcages github issues for some problem they are facing. I wonder if there is some middle ground here that allows for linking after comments are locked and doesn't leave issues overrun and tidymodels / tidyverse team slammed with notifications.)

@juliasilge
Copy link
Member

Ah, we can link to the locked issues and have the link show up because we are "collaborators" on each repo but other contributors or users cannot.

I don't believe there is a way to lock the issues and still allow external folks to link to it with a visible reference (I guess that is kind of the point) so maybe we should update our wording on the locked issues? I do think it may still be useful direction for folks to put in a link to something they want further addressed, even if a reference isn't autogenerated. 🤔

@brshallo
Copy link
Author

Posted idea for being able to lock issues and still accrue references: community/community#4850 (no response). Perhaps I just prefer being able to occasionally pollute your closed issues at my leisure 😅.

Wording is fine. Maybe could change:

"and link to this issue" to "and include a link to this issue"
(which might be more clear to user are not "linking" the issue via github's automatic cross-linking, but simply including a URL on the new issue, but probably doesn't matter either way... I could do a PR, otherwise could close.)

@brshallo
Copy link
Author

brshallo commented Aug 19, 2021

I think why I like the idea of allowing references on closed issues is related to the practices I try to follow regarding cross-posting:

🔗 Always link to your other posts, and update everywhere with any solutions

-Rstudio Community FAQ: Is it OK to Cross-Post

(Though of course the practices for help sites are different from those for github.)

@juliasilge
Copy link
Member

I am very similar and like to cross-link a lot so I can easily find things later. For now, we do want to keep the lock files functioning as they are (not any great alternatives at this moment) and I think there is still value in encouraging people to add a link to something they want to see further addressed, even if there is no autogenerated, visible link created on both sides.

I do think your suggested wording is a bit better and more clear; let's at least update that here and then we can eventually get it updated on all the repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants