R 3.6 breaks clm and clmm tidiers

[IndrajeetPatil]

Both of these issues were not present for R 3.5.1. But my package Travis builds were failing on the development version because of these issues and that's how I found about them.

# setup
set.seed(123)
library(ordinal)

# model
clm_mod <- clm(rating ~ temp * contact, data = wine)
clmm_mod <- clmm(rating ~ temp + contact + (1 | judge), data = wine)

## issue 1

# replacement has 1 row, data has 0
broom::tidy(
  x = clm_mod ,
  conf.int = TRUE,
  conf.level = 0.95,
  quick = FALSE,
  conf.type = "Wald",
  ...
)
#> Registered S3 method overwritten by 'dplyr':
#>   method               from  
#>   as.data.frame.tbl_df tibble
#> Error in eval(expr, envir, enclos): '...' used in an incorrect context

broom::tidy(
  x = clmm_mod ,
  conf.int = TRUE,
  conf.level = 0.95,
  quick = FALSE,
  conf.type = "Wald",
  ...
)
#> Error in eval(expr, envir, enclos): '...' used in an incorrect context


## issue 2

# replacement has 1 row, data has 0
broom::tidy(
  x = clm_mod ,
  conf.int = TRUE,
  conf.level = 0.95,
  quick = FALSE,
  conf.type = "Wald"
)
#> Error in `[<-.data.frame`(`*tmp*`, ret$term %in% names(x$zeta), "coefficient_type", : replacement has 1 row, data has 0

broom::tidy(
  x = clmm_mod ,
  conf.int = TRUE,
  conf.level = 0.95,
  quick = FALSE,
  conf.type = "Wald"
)
#> Error in `[<-.data.frame`(`*tmp*`, ret$term %in% names(x$zeta), "coefficient_type", : replacement has 1 row, data has 0

# session info
devtools::session_info()
#> - Session info ----------------------------------------------------------
#>  setting  value                                             
#>  version  R Under development (unstable) (2018-10-20 r75474)
#>  os       Windows 10 x64                                    
#>  system   x86_64, mingw32                                   
#>  ui       RTerm                                             
#>  language (EN)                                              
#>  collate  English_United States.1252                        
#>  ctype    English_United States.1252                        
#>  tz       America/New_York                                  
#>  date     2018-10-21                                        
#> 
#> - Packages --------------------------------------------------------------
#>  package     * version   date       lib source                      
#>  assertthat    0.2.0     2017-04-11 [1] CRAN (R 3.5.1)              
#>  backports     1.1.2     2017-12-13 [1] CRAN (R 3.5.0)              
#>  base64enc     0.1-3     2015-07-28 [1] CRAN (R 3.5.0)              
#>  bindr         0.1.1     2018-03-13 [1] CRAN (R 3.5.1)              
#>  bindrcpp      0.2.2     2018-03-29 [1] CRAN (R 3.5.1)              
#>  broom         0.5.0     2018-07-17 [1] CRAN (R 3.5.1)              
#>  callr         3.0.0     2018-08-24 [1] CRAN (R 3.5.1)              
#>  cli           1.0.1     2018-09-25 [1] CRAN (R 3.5.1)              
#>  crayon        1.3.4     2017-09-16 [1] CRAN (R 3.5.1)              
#>  desc          1.2.0     2018-05-01 [1] CRAN (R 3.5.1)              
#>  devtools      2.0.0     2018-10-19 [1] CRAN (R 3.6.0)              
#>  digest        0.6.18    2018-10-10 [1] CRAN (R 3.5.1)              
#>  dplyr         0.7.7     2018-10-16 [1] CRAN (R 3.5.1)              
#>  evaluate      0.12      2018-10-09 [1] CRAN (R 3.5.1)              
#>  fs            1.2.6     2018-08-23 [1] CRAN (R 3.5.1)              
#>  glue          1.3.0     2018-07-17 [1] CRAN (R 3.5.1)              
#>  htmltools     0.3.6     2017-04-28 [1] CRAN (R 3.5.1)              
#>  knitr         1.20      2018-02-20 [1] CRAN (R 3.5.1)              
#>  lattice       0.20-35   2017-03-25 [2] CRAN (R 3.6.0)              
#>  magrittr      1.5       2014-11-22 [1] CRAN (R 3.5.1)              
#>  MASS          7.3-51    2018-10-16 [2] CRAN (R 3.6.0)              
#>  Matrix        1.2-14    2018-04-13 [2] CRAN (R 3.6.0)              
#>  memoise       1.1.0     2017-04-21 [1] CRAN (R 3.5.1)              
#>  nlme          3.1-137   2018-04-07 [2] CRAN (R 3.6.0)              
#>  numDeriv      2016.8-1  2016-08-27 [1] CRAN (R 3.5.0)              
#>  ordinal     * 2018.8-25 2018-08-25 [1] CRAN (R 3.5.1)              
#>  pillar        1.3.0     2018-07-14 [1] CRAN (R 3.5.1)              
#>  pkgbuild      1.0.2     2018-10-16 [1] CRAN (R 3.5.1)              
#>  pkgconfig     2.0.2     2018-08-16 [1] CRAN (R 3.5.1)              
#>  pkgload       1.0.1     2018-10-11 [1] CRAN (R 3.5.1)              
#>  prettyunits   1.0.2     2015-07-13 [1] CRAN (R 3.5.1)              
#>  processx      3.2.0     2018-08-16 [1] CRAN (R 3.5.1)              
#>  ps            1.2.0     2018-10-16 [1] CRAN (R 3.5.1)              
#>  purrr         0.2.5     2018-05-29 [1] CRAN (R 3.5.1)              
#>  R6            2.3.0     2018-10-04 [1] CRAN (R 3.5.1)              
#>  Rcpp          0.12.19   2018-10-01 [1] CRAN (R 3.5.1)              
#>  remotes       2.0.1     2018-10-19 [1] CRAN (R 3.6.0)              
#>  rlang         0.3.0     2018-10-21 [1] Github (r-lib/rlang@d773ee9)
#>  rmarkdown     1.10      2018-06-11 [1] CRAN (R 3.5.1)              
#>  rprojroot     1.3-2     2018-01-03 [1] CRAN (R 3.5.1)              
#>  sessioninfo   1.1.0     2018-09-25 [1] CRAN (R 3.5.1)              
#>  stringi       1.2.4     2018-07-20 [1] CRAN (R 3.6.0)              
#>  stringr       1.3.1     2018-05-10 [1] CRAN (R 3.5.1)              
#>  testthat      2.0.1     2018-10-13 [1] CRAN (R 3.5.1)              
#>  tibble        1.4.2     2018-01-22 [1] CRAN (R 3.5.1)              
#>  tidyr         0.8.1     2018-05-18 [1] CRAN (R 3.5.1)              
#>  tidyselect    0.2.5     2018-10-11 [1] CRAN (R 3.5.1)              
#>  ucminf        1.1-4     2016-08-18 [1] CRAN (R 3.5.0)              
#>  usethis       1.4.0     2018-08-14 [1] CRAN (R 3.5.1)              
#>  withr         2.1.2     2018-03-15 [1] CRAN (R 3.5.1)              
#>  yaml          2.2.0     2018-07-25 [1] CRAN (R 3.5.1)              
#> 
#> [1] C:/Users/inp099/Documents/R/win-library/3.6
#> [2] C:/Program Files/R/R-devel/library

^{Created on 2018-10-21 by the reprex package (v0.2.1)}

[IndrajeetPatil]

If I am not mistaken, #550 fixes issue 2 mentioned above! At least it seems to be working for me now.

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.