Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using {cli} #315

Merged
merged 4 commits into from Dec 4, 2023
Merged

Start using {cli} #315

merged 4 commits into from Dec 4, 2023

Conversation

EmilHvitfeldt
Copy link
Member

This PR is a bundle of joy.

  • it switches from abort() to cl_abort() a couple of places
  • Adds check_param() and uses it

hfrick
hfrick approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! 🥳 I've just added a news entry so that we don't forget, and also can keep track of the PRs going into this.

@hfrick hfrick merged commit 6519f7e into main Dec 4, 2023
11 checks passed
@hfrick hfrick deleted the use-cli branch December 4, 2023 11:52
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hfrick hfrick hfrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EmilHvitfeldt @hfrick