Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing infrastructure tests #181

Closed
EmilHvitfeldt opened this issue Apr 27, 2023 · 1 comment · Fixed by #183
Closed

Add missing infrastructure tests #181

EmilHvitfeldt opened this issue Apr 27, 2023 · 1 comment · Fixed by #183
Labels
upkeep maintenance, infrastructure, and similar

Comments

@EmilHvitfeldt
Copy link
Member

bake method errors when needed non-standard role columns are missing

c(
"tests/testthat/test-pca_sparse.R",
"tests/testthat/test-pca_truncated.R"                                    
)

empty printing

c(
"tests/testthat/test-discretize_cart.R", 
"tests/testthat/test-discretize_xgb.R",                             
"tests/testthat/test-embed.R", 
"tests/testthat/test-feature_hash.R", 
"tests/testthat/test-lencode_bayes.R", 
"tests/testthat/test-lencode_glm.R", 
"tests/testthat/test-lencode_mixed.R", 
"tests/testthat/test-pca_sparse.R", 
"tests/testthat/test-pca_sparse_bayes.R", 
"tests/testthat/test-pca_truncated.R", 
"tests/testthat/test-umap.R", 
"tests/testthat/test-woe.R"
)

empty selection prep/bake is a no-op

c(
"tests/testthat/test-discretize_cart.R", 
"tests/testthat/test-discretize_xgb.R",                             
"tests/testthat/test-embed.R", 
"tests/testthat/test-feature_hash.R", 
"tests/testthat/test-lencode_bayes.R", 
"tests/testthat/test-lencode_glm.R", 
"tests/testthat/test-lencode_mixed.R", 
"tests/testthat/test-pca_sparse.R", 
"tests/testthat/test-pca_sparse_bayes.R", 
"tests/testthat/test-pca_truncated.R", 
"tests/testthat/test-umap.R", 
"tests/testthat/test-woe.R"
)

empty selection tidy method works

c(
"tests/testthat/test-discretize_cart.R", 
"tests/testthat/test-discretize_xgb.R",                             
"tests/testthat/test-embed.R", 
"tests/testthat/test-feature_hash.R", 
"tests/testthat/test-lencode_bayes.R", 
"tests/testthat/test-lencode_glm.R", 
"tests/testthat/test-lencode_mixed.R", 
"tests/testthat/test-pca_sparse.R", 
"tests/testthat/test-pca_sparse_bayes.R", 
"tests/testthat/test-pca_truncated.R", 
"tests/testthat/test-umap.R", 
"tests/testthat/test-woe.R"
)

printing

"tests/testthat/test-pca_sparse.R"  
@EmilHvitfeldt EmilHvitfeldt added the upkeep maintenance, infrastructure, and similar label Apr 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant