Data first functions

[DavisVaughan]

scream(new_data, preprocessor, outcome) not scream(preprocessor, new_data, outcome)

[DavisVaughan]

Actually don't do this. To be consistent everywhere we'd have to make forge() do the same thing, but it is S3 on the preprocessor argument. This would mean we would need to do UseMethod("forge", "preprocessor") because it would then be the second arg. This wouldn't be the end of the world but it likely more confusing that it would need to be.

[DavisVaughan]

Hmm, maybe do this with scream() and shrink() because they return new_data back as the output, but don't do it with forge() because it returns a more complicated object back (not pipeable anyways).

Nah, better to be consistent throughout

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.