Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming of functions #11

Closed
beanumber opened this issue Jun 27, 2017 · 4 comments
Closed

naming of functions #11

beanumber opened this issue Jun 27, 2017 · 4 comments

Comments

@beanumber
Copy link
Contributor

Instead of generate() with different types, would it be better to have simulate(), bootstrap() and permute() just be separate functions? They are "verbs" after all... Wouldn't this make it even clearer what is happening?

@andrewpbray
Copy link
Collaborator

Mmm, I have a slight preference to keep them united under generate(), because it underlines the idea that there are all ways to generate more data. I could be convinced otherwise, though, if others feel strongly.

@mine-cetinkaya-rundel
Copy link
Collaborator

I'd also prefer to keep it all the same. I think there is benefit to being able to keep names of steps the same. Otherwise I feel like we would spend a lot of energy explaining the differences (so people learn to use the right one) and I'm not sure that's the main thing we want to emphasize. Do others agree?

@andrewpbray
Copy link
Collaborator

That's a good point. As long as they always use those save 3 verbs, they should be in decent shape; we'll be able to hopefully write sufficient error messages within each to coax them into doing the right thing.

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants