Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure check_name() is used everywhere it needs to be used #983

Closed
EmilHvitfeldt opened this issue May 17, 2022 · 2 comments · Fixed by #1124
Closed

Make sure check_name() is used everywhere it needs to be used #983

EmilHvitfeldt opened this issue May 17, 2022 · 2 comments · Fixed by #1124
Labels
upkeep maintenance, infrastructure, and similar

Comments

@EmilHvitfeldt
Copy link
Member

At least step_geodist() uses a custom checking which should be replaced with check_name()

https://github.com/tidymodels/recipes/blob/main/R/geodist.R#L159-L161
@EmilHvitfeldt EmilHvitfeldt added the upkeep maintenance, infrastructure, and similar label May 17, 2022
@EmilHvitfeldt
Copy link
Member Author

Added corresponding bullet to #960

@EmilHvitfeldt EmilHvitfeldt mentioned this issue Apr 5, 2023
Merged
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use check_name() in all steps that produces new columns tidymodels/recipes
1 participant
@EmilHvitfeldt