Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling assessment() on a permutations gives a confusing error #321

Closed
mikemahoney218 opened this issue Jun 29, 2022 · 2 comments · Fixed by #322
Closed

Calling assessment() on a permutations gives a confusing error #321

mikemahoney218 opened this issue Jun 29, 2022 · 2 comments · Fixed by #322

Comments

@mikemahoney218
Copy link
Member

Related: I am now seeing that the error thrown when calling assessment() on a permutations object is not correct:

library(rsample)

p <- permutations(mtcars, cyl)

assessment(p$splits[[1]])
#> Error in `as.data.frame()`:
#> ! There is no assessment data set for an `rsplit` object with class `rsplit`.

It should read something like:

#> ! There is no assessment data set for an rsplit object from a permutations set.

Or something along those lines...

Originally posted by @mattwarkentin in #319 (comment)

This was referenced Jun 29, 2022
@juliasilge
Copy link
Member

We also do need to add permutations() to the vctrs compatibility files. I think it should just act like other rsets? In terms of binding rows/columns? Worth a little thought, though.

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants