Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name of k argument of k_means() #56

Closed
EmilHvitfeldt opened this issue Jul 10, 2022 · 2 comments · Fixed by #59
Closed

Change name of k argument of k_means() #56

EmilHvitfeldt opened this issue Jul 10, 2022 · 2 comments · Fixed by #59
Labels
Discussion 💬 We are still trying to finalize how and what to do

Comments

@EmilHvitfeldt
Copy link
Member

What should be the name?

  • clusters
  • centers
  • n_clusters
  • num_clusters
@EmilHvitfeldt EmilHvitfeldt added the Discussion 💬 We are still trying to finalize how and what to do label Jul 10, 2022
@kbodwin
Copy link
Collaborator

kbodwin commented Jul 11, 2022

Definitely not "centers", because not all methods have centers, and consistency would be good.

I don't like "clusters" just because that is ambiguous with "cluster labels" or "cluster assignments"

I'm fine with either of the last two. Slight preference for num_clusters, I suppose.

@EmilHvitfeldt EmilHvitfeldt mentioned this issue Jul 19, 2022
Merged
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Discussion 💬 We are still trying to finalize how and what to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finally change k -> num_clusters tidymodels/tidyclust
2 participants
@EmilHvitfeldt @kbodwin