Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fall_out() and miss_rate() (i.e. FPR and FNR) to complement sens() and spec() #336

Open
deschen1 opened this issue Oct 26, 2022 · 1 comment
Labels
feature a feature request or enhancement metric 📏 a new yardstick metric

Comments

@deschen1
Copy link

Not sure if I'm missing something obvious, but I didn't find the false positive rate among the available metrics in yardstick. I know I could simply calculate it by doing 1 - specificity, but it feels like an unnecessary extra step when there are many other metrics available by default in yardstick.

https://yardstick.tidymodels.org/articles/metric-types.html

@DavisVaughan
Copy link
Member

# We have:
true positive rate = sensitivity(), recall()
true negative rate = specificity()

# We don't have:
false positive rate = fall_out()
false negative rate = miss_rate()

If we decide to add these:

Since we went with sensitivity() and specificity() instead of true_positive_rate() and true_negative_rate(), I'd advocate for fall_out() and miss_rate() over false_positive_rate() or false_negative_rate() just to be consistent. The docs can mention that they are equivalent

@DavisVaughan DavisVaughan changed the title [Feature request] Adding false positive rate (and other basic metrics) as metrics fall_out() and miss_rate() (i.e. FPR and FNR) to complement sens() and spec() Oct 27, 2022
@DavisVaughan DavisVaughan added feature a feature request or enhancement metric 📏 a new yardstick metric labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement metric 📏 a new yardstick metric
Projects
None yet
Development

No branches or pull requests

2 participants