Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential error in description of event_level across several metrics #432

Closed
bgreenwell opened this issue May 8, 2023 · 2 comments · Fixed by #486
Closed

Potential error in description of event_level across several metrics #432

bgreenwell opened this issue May 8, 2023 · 2 comments · Fixed by #486

Comments

@bgreenwell
Copy link

The docs for several metric functions (e.g., roc_auc) mention that the default behavior of event_level still uses the global option if set:

A single string. Either "first" or "second" to specify which level of truth to consider as the "event". This argument is only applicable when estimator = "binary". The default uses an internal helper that generally defaults to "first", however, if the deprecated global option yardstick.event_first is set, that will be used instead with a warning.

However, it appears that the default is always "first"?

> packageVersion("yardstick")
[1] ‘1.2.0> yardstick:::yardstick_event_level
function () 
{
    opt <- getOption("yardstick.event_first")
    if (!is.null(opt)) {
        lifecycle::deprecate_warn(when = "0.0.7", what = I("The global option `yardstick.event_first`"), 
            with = I("the metric function argument `event_level`"), 
            details = "The global option is being ignored entirely.")
    }
    "first"
}
@EmilHvitfeldt
Copy link
Member

Hello @bgreenwell 👋

thanks for the keen eye, I'll have that fixed!

Copy link

github-actions bot commented Feb 3, 2024

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants