Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small motion optimization suggestion #3

Open
maxsbelt opened this issue Jul 7, 2019 · 1 comment
Open

Small motion optimization suggestion #3

maxsbelt opened this issue Jul 7, 2019 · 1 comment

Comments

@maxsbelt
Copy link

maxsbelt commented Jul 7, 2019

Thanks for good project! I was surfing through the code and noticed that keyframes calls in all components are wrapped with additional function that actually isn't necessary. I think such modification can increase performance a little bit. WDYT?

Screenshot 2019-07-07 at 20 58 20

@tienpham94
Copy link
Owner

Hi @maxsbelt thank you for checking out the project! Yeah the props passing was initially done because I wanted to make it customizable, but its not anymore needed. I will improve that in the next release, thank you for commenting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants