Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some file colors are illegible in Latte #20

Closed
Tracked by #22
vctls opened this issue Oct 23, 2022 · 3 comments
Closed
Tracked by #22

Some file colors are illegible in Latte #20

vctls opened this issue Oct 23, 2022 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@vctls
Copy link

vctls commented Oct 23, 2022

Just installed v2 via the released file on PhpStorm 2022.2.3.
Although they work well in Mocha and Macchiato, some file colors don't seem to have their corresponding match in Latte.
image

I could use custom colors, but then those wouldn't change when switching from light to dark theme.

@sgoudham
Copy link
Contributor

Ah, thanks for bringing this to our attention!

It looks like the violating code is around here where I'm bringing down the opacity but forgot to consider Latte which wouldn't look the best!

This should be a somewhat easy fix. I'll try to get around to this by the end of the day and bump up the release to a minor version. Unfortunately uploading it to the marketplace seems to have a manual review process so that would take longer.

If you are still wanting to use Latte, I'd recommend disabling the file colours for now 👍

@vctls
Copy link
Author

vctls commented Oct 23, 2022

Wow, you sure are quick! 😄
It's nothing critical. I can use one of the working colors for now.

@sgoudham
Copy link
Contributor

Haha! Sorry I missed this in my testing. I tested file colours and then disabled them but forgot to test Latte at the time.

Hope you are enjoying the other colours more 😅

@sgoudham sgoudham added the bug Something isn't working label Oct 23, 2022
@sgoudham sgoudham added this to the v2.0.1 milestone Oct 23, 2022
sgoudham added a commit that referenced this issue Oct 24, 2022
closes #20

Co-authored-by: winston <hey@winston.sh>
@sgoudham sgoudham mentioned this issue Oct 24, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants