Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting comments makes them unreadable #24

Closed
christopherdmgunn opened this issue Oct 27, 2022 · 5 comments
Closed

Highlighting comments makes them unreadable #24

christopherdmgunn opened this issue Oct 27, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@christopherdmgunn
Copy link

When selecting comments they become unreadable.

All three dark modes:

image

Light Mode
image

Is there a way to dynamically change comment colour based on highlight to account?

@sgoudham sgoudham added the bug Something isn't working label Oct 27, 2022
@sgoudham sgoudham changed the title [Bug] Highlighting comments makes them unreadable Highlighting comments makes them unreadable Oct 27, 2022
@sgoudham
Copy link
Contributor

sgoudham commented Oct 27, 2022

Hey 👋, thanks for raising this.

On my installation, the highlights currently look like this:

Mocha
image

Latte
image

which don't seem nearly as bad as the highlights raised in your issue. Could you please screenshot your settings like mine down below?

The path is File > Settings > Editor > Color Scheme > General
Within the highlight box, it should be Editor > Selection Foreground
image

Just one other thing, could you please ensure that you have clicked Restore Defaults on the colour scheme that you are using.
This ensures that all the highlights are as they should be!
image

@christopherdmgunn
Copy link
Author

Hi please find attached for both latte and mocha. No settings have been changed and the restore defaults setting is not selectable as nothing has been changed.
Catpuccin bug 2
Catpuccin bug 2 1
Catpuccin bug 2 2

@christopherdmgunn
Copy link
Author

Sorry realised I hadn't applied mocha but the contents are still the same
image

@sgoudham
Copy link
Contributor

Huh that's quite interesting, I can reproduce it on my local installation now but when debugging the code (running another IDE for development)... it works as expected o.o

I think I'll need to do some extra digging on this!

@sgoudham
Copy link
Contributor

sgoudham commented Oct 31, 2022

This should be closed with the release of v2.0.2!

Please allow up to 2 business days for it to appear on the marketplace! If you can't wait, you can download the jar from the release and import it into your IDE. Thanks again for raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants