Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Tests call await client.destroy(), but destroy() doesn't return a promise #32

Open
lewisdaly opened this issue Sep 16, 2022 · 0 comments

Comments

@lewisdaly
Copy link
Contributor

This is a minor nitpick, but I noticed it and was confused, so I figured I'd open an issue for it.

According to the Client interface, destroy returns void:
https://github.com/tigerbeetledb/tigerbeetle-node/blob/de2272194719a33a013ab5f0a09ce4bead91283c/src/index.ts#L200

But in the tests we have: https://github.com/tigerbeetledb/tigerbeetle-node/blob/de2272194719a33a013ab5f0a09ce4bead91283c/src/test.ts#L343

I'm guessing that the line in the tests are a simple typo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant