Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages for --limit-storage etc should use appropriate byte units #1465

Closed
brson opened this issue Jan 25, 2024 · 0 comments · Fixed by #1565
Closed

Error messages for --limit-storage etc should use appropriate byte units #1465

brson opened this issue Jan 25, 2024 · 0 comments · Fixed by #1565
Assignees
Labels
enhancement New feature or request

Comments

@brson
Copy link
Contributor

brson commented Jan 25, 2024

The error messages for --storage-size-limit print information about the low/high/multiples allowed for the argument. These are printed in bytes (but not labeled as bytes). These arguments accept a variety of units, eg "1024", "1KB" ,"1MB", and it is usually best to provide the argument in such units, not bytes.

Example:

$ ./tigerbeetle start --addresses=3000 --limit-storage=0 0_0.tigerbeetle
error: --storage-size-limit: size 0 is below minimum: 1108344832

These messages should print their numbers in a more readable unit, probably MB. The --cache-grid argument already does so.

This may soon be true for --memory-lsm-manifest as well cc #1447

@brson brson added enhancement New feature or request good first issue Good for newcomers labels Jan 25, 2024
@brson brson removed the good first issue Good for newcomers label Mar 11, 2024
@brson brson self-assigned this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant