Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with right-shift in Gear rollsum. #3

Closed
dbaarda opened this issue Feb 9, 2021 · 1 comment
Closed

Problems with right-shift in Gear rollsum. #3

dbaarda opened this issue Feb 9, 2021 · 1 comment

Comments

@dbaarda
Copy link

dbaarda commented Feb 9, 2021

This implementation copies another implementation that uses a right-shift in its Gear rollsum. This has problems I reported here;

ronomon/deduplication#7

@tigerwill90
Copy link
Owner

I read your recommendations as well as the very interesting analysis you carried out. I will tests and benchmark your recommendations on optimal and speed chunking. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants