Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not store token in settings.json #21

Open
osya opened this issue Apr 4, 2019 · 0 comments
Open

Do not store token in settings.json #21

osya opened this issue Apr 4, 2019 · 0 comments

Comments

@osya
Copy link

osya commented Apr 4, 2019

Do not store token in the settings.json. Use context.globalState, for example, similar to the GitLab Workflow extension. Currently when token stored in the settings.json and settings.json synced via Settings Sync and stored in Gists it is potential security flaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@osya