Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewing post fails when gist markdown preview is less than 200 html characters #61

Closed
JacobBennett opened this issue Jul 23, 2015 · 2 comments
Closed

Viewing post fails when gist markdown preview is less than 200 html characters #61

JacobBennett opened this issue Jul 23, 2015 · 2 comments
Labels
bug

Comments

@JacobBennett
Copy link
Contributor

As seen here

https://github.com/tightenco/gistlog/blob/master/app/Gists/Gistlog.php#L98

The preview assumes a length of at least 200 characters when rendering the preview. Will submit a PR for this but wanted to make an issue before I forgot.
JacobBennett added a commit to JacobBennett/gistlog that referenced this issue Jul 24, 2015
@JacobBennett
Fix preview breaking for gistlog < 200 chars
a280025 
Should return full body of gistlog for a preview when the body length is less than the default preview length of 200.

reference Issue tighten#61
@JacobBennett JacobBennett mentioned this issue Jul 24, 2015
Merged
@JacobBennett
Copy link
Contributor Author

@mattstauffer should be good to go on this. Quick fix!

@JacobBennett
Copy link
Contributor Author

fixed in 1ab5009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattstauffer @JacobBennett