Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disqus Comments #49

Closed
atymic opened this issue Sep 7, 2019 · 3 comments
Closed

Disqus Comments #49

atymic opened this issue Sep 7, 2019 · 3 comments

Comments

@atymic
Copy link
Contributor

atymic commented Sep 7, 2019

Hey!

I was wondering you you'd be open adding disqus comments to the blog template?
I wrote a post on how to do it here but I think it would be a good feature to have integrated.

Let me know, would be happy to PR.

@mattstauffer
Copy link
Member

Hey @atymic! Thanks for sharing! I don't think we want to have this included in the template out of the box, but we have two other options:

  1. We'd love to link that article at https://builtwithjigsaw.com/ if that's OK by you
  2. We intend to add a section to the docs with solutions for common tasks and this would be a wonderful fit for it, if you wouldn't mind either helping us repurpose it for that (with attribution) or link to it. We're not there quite yet but hope to get to it soon.

@atymic
Copy link
Contributor Author

atymic commented Sep 9, 2019

We'd love to link that article at builtwithjigsaw.com if that's OK by you

That would be fine, no worries.

We intend to add a section to the docs with solutions for common tasks and this would be a wonderful fit for it, if you wouldn't mind either helping us repurpose it for that (with attribution) or link to it. We're not there quite yet but hope to get to it soon.

Either is fine by me :)
I'll have a look at the docs and see if I can make a PR.

@atymic
Copy link
Contributor Author

atymic commented Oct 30, 2019

Would you like me to make a PR against the docs?

@atymic atymic closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants