Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Link to reasons/discussions on tests #106

Closed
minthemiddle opened this issue Oct 3, 2019 · 3 comments
Closed

Discussion: Link to reasons/discussions on tests #106

minthemiddle opened this issue Oct 3, 2019 · 3 comments
Assignees

Comments

@minthemiddle
Copy link

  • tlint is fantastic to follow best practices
  • For learning it would be even more useful, if there was a linked why? for each test
  • These could be links to discussions or articles
  • For example I could not easily find an explanation for NoMethodVisibilityInTestsTest
@loganhenson
Copy link
Contributor

I love this idea!

Some of these are from in person discussions though, and will have to be reconstructed.

I am open to PRs that add reasoning to the lint names in the readme, and will try to extract the discussions where I can from the tighten notes there!

For NoMethodVisibilityInTestsTest, I believe the primary point was in a standard PhpUnit suite the test method visibility is redundant (you usually aren't new-ing up PhpUnit class instances).

@loganhenson loganhenson changed the title Enhancement: Link to reasons/discussions on tests Discussion: Link to reasons/discussions on tests Oct 3, 2019
@loganhenson loganhenson self-assigned this Oct 11, 2019
@loganhenson
Copy link
Contributor

We are adding to the readme incrementally as discussion comes up or is revisited 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@minthemiddle @loganhenson and others