Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Commit

Permalink
Minor cleanup on more-than-thirty-gists PR.
Browse files Browse the repository at this point in the history
  • Loading branch information
mattstauffer committed Oct 30, 2017
1 parent 029d627 commit 29a9bf6
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .env.test.example
@@ -1,4 +1,4 @@
GITHUB_ID=
GITHUB_SECRET=
TESTING_USER_API_TOKEN=
TESTING_USER_GITHUB_API_TOKEN=
TEST_API=false
7 changes: 2 additions & 5 deletions app/GistClient.php
Expand Up @@ -25,11 +25,8 @@ private function pagedAuthenticatedCall($api, $method, $user, $parameters = [])
$api = $this->client->api($api);

$paginator = new ResultPager($this->client);
$parameters = array_merge(['github'], $parameters); // wut?
$result = $paginator->fetchAll($api, $method, $parameters);
$parameters = array_merge(['github'], $parameters);

// @todo: Can we un-authenticate now?
return $result;
return $paginator->fetchAll($api, $method, $parameters);
}
}
2 changes: 1 addition & 1 deletion tests/CancelUserTest.php
Expand Up @@ -5,7 +5,7 @@
use App\Jobs\NotifyUserOfNewGistComments;
use App\User;
use Illuminate\Foundation\Testing\DatabaseMigrations;
use Mail;
use Illuminate\Support\Facades\Mail;

class CancelUserTest extends TestCase
{
Expand Down
2 changes: 1 addition & 1 deletion tests/GistClientTest.php
Expand Up @@ -23,7 +23,7 @@ class GistClientTest extends TestCase
*/
public function itPullsMoreThan30GistsFromTestingUsersAccount()
{
$token = env('TESTING_USER_API_TOKEN');
$token = env('TESTING_USER_GITHUB_API_TOKEN');
$user = factory(User::class)->create([
'token' => $token
]);
Expand Down

0 comments on commit 29a9bf6

Please sign in to comment.