remove composer.lock from gitignore

[zaherg]

based on getcomposer.org recommendation at https://getcomposer.org/doc/01-basic-usage.md#commit-your-composer-lock-file-to-version-control it is important to have composer.lock within git.

Committing this file to VC is important because it will cause anyone who sets up the project to use the exact same versions of the dependencies that you are using. Your CI server, production machines, other developers in your team, everything and everyone runs on the same dependencies, which mitigates the potential for bugs affecting only some parts of the deployments. Even if you develop alone, in six months when reinstalling the project you can feel confident the dependencies installed are still working even if your dependencies released many new versions since then. (See note below about using the update command.)

I know that there are some debate whether we should have this within frameworks or not, but if am not mistaken Jigsaw is an application not a framework.

More info about why we should have composer.lock within git was mentioned here https://www.engineyard.com/blog/composer-its-all-about-the-lock-file

[pedzed]

if am not mistaken Jigsaw is an application not a framework.

Technically, it is a framework; a set of tools pushing you to write code in a certain way. An application would mean that it is ready for end-users to use.

I would agree, it is good practice to keep the Lock file in.

[zaherg]

We will always have a debate weather it is an application or a framework, as for example I cant say that Laravel Mix is a framework, its a tool, the same thing with Jigsaw in my opinion, it is just a set of tool that any user can use it, remember each one of us can define a different specification for the word end-users.

What can help us is to define who is the end-user for Jigsaw, a designer, a programmer or anyone with few knowledge of markup?

[pedzed]

What can help us is to define who is the end-user for Jigsaw, a designer, a programmer or anyone with few knowledge of markup?

The end-user is the user at the end? I.e. the one who visits and uses the website/web application. The programmer or designer just writes it for the end-user.

I haven't ever thought that there would be a different interpretation to it, but sure. Personally I find it odd, but if you want to define it differently, that's fine.

[zaherg]

Based on that the end user has no interest in jigsaw or what files we include or exclude from it.and they only care about the website they visit with the mabojambo style and layout From my mobile, Please excuse any awkward autocorrections or typos.

…

On Sat, Aug 25, 2018, 5:16 PM Ped ***@***.***> wrote: What can help us is to define who is the end-user for Jigsaw, a designer, a programmer or anyone with few knowledge of markup? The end-user is the user at the end? I.e. the one who visits and uses the website/web application. The programmer or designer just writes it for the end-user. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#244 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABr6CvXhSiFWTK_9pDlsdvOYF0gdrj_ks5uUVxMgaJpZM4VwknZ> .