Skip to content

Commit

Permalink
feat: Publish to NPM registry
Browse files Browse the repository at this point in the history
  • Loading branch information
@efirs
efirs committed Nov 3, 2022
1 parent 946feec commit b0808d7
Show file tree
Hide file tree
Showing 3 changed files with 1,149 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/go-releaser.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,8 @@ jobs:
run: |
API_KEY=${{secrets.SHORTS_IO_KEY}} VERSION=${GITHUB_REF/refs\/tags\//} /bin/bash scripts/publish.sh
- name: Publish to NPM

This comment has been minimized.

Sign in to view

Copy link
@adilansari

adilansari Nov 3, 2022

Contributor

This is getting published to latest tag in npm, should we rather publish it under beta channel?

This comment has been minimized.

Sign in to view

Copy link
@adilansari

adilansari Nov 3, 2022

Contributor

Check versions for both:
https://www.npmjs.com/package/@tigrisdata/core
https://www.npmjs.com/package/@tigrisdata/tigris-cli

This comment has been minimized.

Sign in to view

Copy link
@ovaistariq

ovaistariq Nov 3, 2022

Collaborator

@adilansari actually there is a problem publishing to beta channel only. People generally expect latest to have the latest available version but in our case latest is behind beta.

As you can see https://www.npmjs.com/package/@tigrisdata/core also shows the latest tag on the main page. Should we fix this?
run: |
npm version ${GITHUB_REF/refs\/tags\//}
npm publish --access public
Loading

0 comments on commit b0808d7

Please sign in to comment.