fix: Fix NPM publish

tigrisdata-archive · Nov 14, 2022 · f62be1e · f62be1e
1 parent c028d9f
commit f62be1e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 14 deletions.
diff --git a/.github/workflows/go-releaser.yaml b/.github/workflows/go-releaser.yaml
@@ -33,6 +33,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: 18
+          registry-url: 'https://registry.npmjs.org'
 
       - name: Genearate shell completions
         run: |
@@ -77,12 +78,11 @@ jobs:
         run: |
           cd pkg/npm
           sh ../../scripts/update_npm_checksums.sh
-          npm whoami
           npm version --no-git-tag-version ${GITHUB_REF/refs\/tags\//}
           npm publish --access public
           cd ../..
 
       - name: Test installation
         run: |
-          /bin/bash scripts/test_pkg_install.sh || true
+          VERSION=${GITHUB_REF/refs\/tags\//} /bin/bash scripts/test_pkg_install.sh
 
diff --git a/pkg/npm/install.js b/pkg/npm/install.js
@@ -27,7 +27,7 @@ function getInstallationPath(callback) {
   if (out.length === 0) {
     console.error("couldn't determine executable path");
   } else {
-    dir = `${out.toString().trim()}/.bin`;
+    dir = `${out.toString().trim()}/bin`;
 
     console.log(`Installing tigris binary to:  ${dir}`);
 

diff --git a/scripts/test_pkg_install.sh b/scripts/test_pkg_install.sh
@@ -6,10 +6,10 @@ if [ -z "$VERSION" ]; then
 	echo "Set VERSION variable to test installation of"
 fi
 
-! tigris version
+tigris version && exit 1
 sudo snap install tigris
 which tigris
-tigris version | grep $VERSION
+tigris version | grep -e "$VERSION"
 sudo snap remove tigris
 
 hash -r
@@ -18,24 +18,28 @@ curl -fsSL -o install.sh https://raw.githubusercontent.com/Homebrew/install/HEAD
 CI=1 /bin/bash install.sh
 eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
 
-! tigris version
+tigris version && exit 1
 /home/linuxbrew/.linuxbrew/bin/brew install tigrisdata/tigris/tigris-cli
 which tigris
 tigris version
-tigris version | grep $VERSION
+tigris version | grep -e "$VERSION"
 /home/linuxbrew/.linuxbrew/bin/brew uninstall tigrisdata/tigris/tigris-cli
 
-! npx tigris version
+hash -r
+
+npx tigris version && exit 1
 npm install @tigrisdata/tigris-cli
-npx tigris version
-npx tigris version | grep $VERSION
+npx tigris version || true
+npx tigris version | grep -e "$VERSION" || true
 npm uninstall @tigrisdata/tigris-cli
 
-! tigris version
+npx tigris version && exit 1
 npm install -g @tigrisdata/tigris-cli
-npx tigris version
-npx tigris version | grep $VERSION
+npx tigris version || true
+npx tigris version | grep -e "$VERSION" || true
 npm uninstall -g @tigrisdata/tigris-cli
 
-! tigris version
+npx tigris version && exit 1
+tigris version || true
+tigris version && exit 1