Schema builder #15

efirs · 2022-03-27T07:00:24Z

No description provided.

ovaistariq · 2022-03-28T00:13:10Z

High level comment - @himank @efirs are we going to have the high level client in this same repo?

efirs · 2022-03-28T04:54:34Z

Yes, I think it natural to have them co-located in the same repo.
And actually ideally we could have Golang client as a part of TigrisDB repo.
Pulling client as

go get github.com/tigrisdata/tigrisdb/client

look nicer to me.

ovaistariq · 2022-03-28T05:23:01Z

Remember that we are not building a "go" only database. We need to make sure all languages have first class support and that the usage is similar.

So it would be unnatural for only the go client to be part of the server repo.

Secondly, tigrisdb allows HTTP access without requiring a special client. Thus, embedding a client in the server repo would not send a coherent message.

Yes, I think it natural to have them co-located in the same repo.

And actually ideally we could have Golang client as a part of TigrisDB repo.

Pulling client as
go get github.com/tigrisdata/tigrisdb/client
look nicer to me.

client/client.go

client/schema.go

client/client.go

client/schema.go

himank · 2022-03-28T21:57:49Z

client/schema.go

+	i := 1
+	if len(pks) > 1 {
+		if len(pks) > 2 {
+			return 0, fmt.Errorf("only one colon allowed in the tag")


Can you add a comment when this can happen?

When user have more then one colon in the tag, for example "trigris:primary_key:a:b". The error message is self-explanatory IMO.
There is a test for it: https://github.com/tigrisdata/tigris-client-go/blob/6d913e6e5187748bdd9208af04e0eb41f25bfc28/schema/schema_test.go#L71

client/schema.go

himank · 2022-03-29T18:02:44Z

High level comment - @himank @efirs are we going to have the high level client in this same repo?

yes, so low level client and high level client will be in same repo - in go client repo.

client/database.go

schema/schema.go

schema/schema_test.go

schema/schema.go

codecov-commenter · 2022-04-26T20:23:28Z

Codecov Report

Merging #15 (622c9cb) into main (b118be7) will increase coverage by 4.17%.
The diff coverage is 87.41%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   80.76%   84.93%   +4.17%     
==========================================
  Files          10       11       +1     
  Lines         863     1082     +219     
==========================================
+ Hits          697      919     +222     
+ Misses        133      123      -10     
- Partials       33       40       +7

Impacted Files	Coverage Δ
client/database.go	`27.08% <33.33%> (-5.35%)`	⬇️
schema/schema.go	`92.24% <92.24%> (ø)`
client/client.go	`36.84% <100.00%> (+36.84%)`	⬆️
driver/driver.go	`97.91% <100.00%> (ø)`
driver/grpc.go	`88.38% <100.00%> (ø)`
driver/http.go	`77.08% <100.00%> (ø)`
driver/internal.go	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b118be7...622c9cb. Read the comment docs.

github-actions · 2022-04-28T21:19:37Z

🎉 This PR is included in version 1.0.0-alpha.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions · 2022-09-20T19:08:34Z

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions · 2023-05-09T23:23:09Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

efirs force-pushed the schema_support branch 4 times, most recently from a236a99 to a878690 Compare March 27, 2022 17:56

efirs force-pushed the schema_support branch from a878690 to cf0a4ae Compare March 28, 2022 05:00

himank reviewed Mar 29, 2022

View reviewed changes

efirs force-pushed the schema_support branch from 2fcff22 to 09f3210 Compare March 29, 2022 18:34

efirs force-pushed the main branch from 8a277df to 1e5becf Compare April 9, 2022 00:56

efirs force-pushed the schema_support branch 2 times, most recently from 806ba2c to 7a0cd6f Compare April 24, 2022 08:31

efirs changed the title ~~Schema support~~ Schema builder Apr 24, 2022

efirs force-pushed the schema_support branch from 7a0cd6f to 5a8754e Compare April 25, 2022 18:02