Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added CDC event stream #80

Merged
merged 9 commits into from
May 16, 2022
Merged

feat: added CDC event stream #80

merged 9 commits into from
May 16, 2022

Conversation

mattayres
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #80 (a5629b5) into main (2f72e1d) will decrease coverage by 4.64%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   83.55%   78.90%   -4.65%     
==========================================
  Files          16       16              
  Lines        1307     1384      +77     
==========================================
  Hits         1092     1092              
- Misses        150      227      +77     
  Partials       65       65              
Impacted Files Coverage Δ
driver/driver.go 91.17% <0.00%> (-5.70%) ⬇️
driver/grpc.go 83.33% <0.00%> (-6.25%) ⬇️
driver/http.go 71.00% <0.00%> (-6.17%) ⬇️
driver/internal.go 100.00% <ø> (ø)
driver/iterator.go 50.00% <0.00%> (-50.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f72e1d...a5629b5. Read the comment docs.

driver/http.go Outdated
return nil, HTTPError(err, nil)
}

event, err := jsoniter.Marshal(res.Result.Event)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, fixed

driver/grpc.go Outdated
return nil, GRPCError(err)
}

event, err := jsoniter.Marshal(resp.Event)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to marshal it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, fixed

@mattayres mattayres merged commit 6516c2c into main May 16, 2022
@mattayres mattayres deleted the cdc_events branch May 16, 2022 22:38
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-alpha.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented May 9, 2023

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants