Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid display of tracing error #581

Merged
merged 1 commit into from
Oct 10, 2022
Merged

fix: invalid display of tracing error #581

merged 1 commit into from
Oct 10, 2022

Conversation

pboros
Copy link
Contributor

@pboros pboros commented Oct 10, 2022

An invalid tracing error was displayed when tracing was turned off, but metrics was turned on.

2022-10-10T05:56:08Z ERR metrics/measurement.go:296 recordTimerDuration was called on a span that was not started ot stopped resource_name=/tigrisdata.v1.Tigris/CreateDatabase service_name=tigris-server

The measurement type is used both by tracing and metrics. So the logic needs to happen even if tracing is turned off.

Added some more debug messages for easier troubleshooting of future issues like this.

@codecov-commenter
Copy link

Codecov Report

Base: 31.48% // Head: 31.46% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b1866fc) compared to base (853434e).
Patch coverage: 16.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   31.48%   31.46%   -0.02%     
==========================================
  Files          96       96              
  Lines       11117    11135      +18     
==========================================
+ Hits         3500     3504       +4     
- Misses       7301     7314      +13     
- Partials      316      317       +1     
Impacted Files Coverage Δ
server/metrics/measurement.go 42.85% <16.00%> (-1.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pboros pboros merged commit 3984943 into main Oct 10, 2022
@pboros pboros deleted the pboros/fix-metrics branch October 10, 2022 11:01
@tigrisdata-argocd-bot
Copy link
Collaborator

🎉 This PR is included in version 1.0.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants