Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$cssRules Memory Leak #105

Closed
jproffitt3ge opened this issue Oct 1, 2015 · 2 comments
Closed

$cssRules Memory Leak #105

jproffitt3ge opened this issue Oct 1, 2015 · 2 comments

Comments

@jproffitt3ge
Copy link
Contributor

I'm using this to inline emails in bulk, and I noticed while profiling that each email I inlined took longer to convert than the last. I traced it back to the "cssRules" variable, which gets appended to every time "processCSS" is called, even if the css and html are exactly the same as the last time it was called.

Is there a reason for this variable to live outside the "convert" function scope? Would it make sense to change the code so that processCSS returns a list of rules rather than modifying any state?

$cssRules = $this->processCSS();
@tijsverkoyen
Copy link
Owner

This will be fixed in #111

@stof
Copy link
Collaborator

stof commented Nov 23, 2015

Actually, this has been fixed by #106 in 1.x, so it should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants