You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using this to inline emails in bulk, and I noticed while profiling that each email I inlined took longer to convert than the last. I traced it back to the "cssRules" variable, which gets appended to every time "processCSS" is called, even if the css and html are exactly the same as the last time it was called.
Is there a reason for this variable to live outside the "convert" function scope? Would it make sense to change the code so that processCSS returns a list of rules rather than modifying any state?
$cssRules = $this->processCSS();
The text was updated successfully, but these errors were encountered:
I'm using this to inline emails in bulk, and I noticed while profiling that each email I inlined took longer to convert than the last. I traced it back to the "cssRules" variable, which gets appended to every time "processCSS" is called, even if the css and html are exactly the same as the last time it was called.
Is there a reason for this variable to live outside the "convert" function scope? Would it make sense to change the code so that processCSS returns a list of rules rather than modifying any state?
The text was updated successfully, but these errors were encountered: